openjpeg icon indicating copy to clipboard operation
openjpeg copied to clipboard

Build meson support

Open dabrain34 opened this issue 4 years ago • 5 comments

Openjpeg is used by GStreamer to support jpeg2000 and as gst-build provides a very easy way to build gstreamer and its depencies using Meson, here is a bunch of commits to add this support, without any changes to the existing CMake build system.

dabrain34 avatar Apr 06 '20 15:04 dabrain34

I'm not sure we want to add a second build system into the library...

rouault avatar Apr 06 '20 15:04 rouault

Sorry I realized that I did not add much to my PR description.

My idea with this PR was to provide the possibility to use openjpeg as a subproject of another meson project (gst-build). I can understand that you dont want to maintain multiple buildsystem.

But as you can see, I did not touch anything in CMake and we can have also the power and flexiility of the trendy Meson.

dabrain34 avatar Apr 06 '20 19:04 dabrain34

openjpeg is insufficiently maintained (by me in particular :-)), so adding more stuff that could rot easily (as I won't use it personnally) is not super compelling.

You might want to raise the issue on the openjpeg mailing list and see if it raises interest from other stakeholders.

by the way the change in libtiff should likely be reverted. libtiff has an upstream (https://gitlab.com/libtiff/libtiff), and openjpeg should not modify it, unless resynchronizing with that upstream

rouault avatar Apr 06 '20 19:04 rouault

No problem I will drop the indent commit in libtiff.

I understand your point regarding the support of 2 build system :)

I just wanted to let you know first of the existence of this port.

dabrain34 avatar Apr 07 '20 07:04 dabrain34

Porting openjpeg to Meson would allow to delete the thirdparty directory completely. Meson has a subproject mechanism made exactly for that use-case. zlib, png, tiff are already available in meson ports (wrapdb) and lcms2 could easily be added too.

xclaesse avatar Oct 14 '21 13:10 xclaesse