ansible-miniconda-role icon indicating copy to clipboard operation
ansible-miniconda-role copied to clipboard

The role needs a rewrite using proper YML syntax

Open lhoss opened this issue 5 years ago • 2 comments

since currently the role is still using the old style (which has various drawbacks and is not at all recommended anymore) .. snippet from the main tasks:

  file:
    path="{{ miniconda_prefix | dirname }}"

( Actually it's mostly replacing a number of = by : )

Other suggestions/wishes I have for this role:

  • main.yml tasks only contain import_tasksto install.yml and environment.yml tasks file (TODO move main logic out into a new install.yml tasks file)
  • avoid any warnings in more recent ansible versions
  • use molecule for the tests (so we can get rid of the existing boilerplate

ps: I checked the existing forks (https://github.com/uchida/ansible-miniconda-role/network) but nobody has done that yet

lhoss avatar Oct 15 '19 14:10 lhoss

Fixed by https://github.com/uchida/ansible-miniconda-role/pull/20

@uchida you still maintain this role?

Todo next fix lint issues:

[602] Don't compare to empty string
/Users/lhoss/work/scigi/ansible-miniconda-role/tasks/environment.yml:9
  when: miniconda_env != '' and miniconda_env.name != 'root'

[204] Lines should be no longer than 160 chars
/Users/lhoss/work/scigi/ansible-miniconda-role/tasks/environment.yml:13
    '"{{ miniconda_prefix }}/bin/conda" env update -n "{{ miniconda_env.name }}" -f "/tmp/{{ miniconda_env.name }}-environment.yml" {{ miniconda_env_update_opts }}'

[602] Don't compare to empty string
/Users/lhoss/work/scigi/ansible-miniconda-role/tasks/main.yml:8
    force: "{{ 'yes' if miniconda_installer_checksum == '' else 'no' }}"

[602] Don't compare to empty string
/Users/lhoss/work/scigi/ansible-miniconda-role/tasks/main.yml:45
  when: miniconda_env != ''

[602] Don't compare to empty string
/Users/lhoss/work/scigi/ansible-miniconda-role/tasks/main.yml:48
  when: miniconda_env != ''

lhoss avatar Oct 31 '19 08:10 lhoss

Looks like this repository is no longer maintained. There is another fork that has some useful additions https://github.com/StudioEtrange/ansible-miniconda-role @studioetrange

Would any of you be interested in continuing to maintain this ansible role under your github account? Please let me know in either cases (yes/no); if you aren't interested I can also look into this.

If you would like assistance with getting it on ansible galaxy, I'm happy to help (it's very straightforward, though).

ltalirz avatar Sep 21 '20 22:09 ltalirz