canvasapi icon indicating copy to clipboard operation
canvasapi copied to clipboard

fix: don't override `per_page` in `PaginatedList`

Open superle3 opened this issue 11 months ago • 1 comments

Proposed Changes

  • Don't override per_page parameter
  • update readme to state 100 is used instead of the 10 default when it is not specified, but we specify it already by default
  • add _kwargs as arg to PaginatedList and change every kwargs=combine_kwargs(**kwargs) to _kwargs=combine_kwargs(**kwargs), since I couldn't find a reason why some were different in the documentation and commits.
  • specify the per_page parameter in the mock requests.

Fixes #685 .

TODO: a test maybe?

superle3 avatar Mar 21 '25 22:03 superle3

fixtures were wrong, updated them and the tests accordingly.

superle3 avatar Mar 22 '25 23:03 superle3