canvasapi
canvasapi copied to clipboard
Comments to submissions are always added to first attempt
When using upload_comment in the submission.py the files that are uploaded are always attached to attempt 1 regardless of which attempt the comment was meant for
To Reproduce
- Submit an assignment to canvas.
- Use upload_comment to attach a file as a comment to the submission attempt.
- Resubmit to the same assignment as the same student.
- Use upload_comment again to upload another file comment.
- See that both files are attached to attempt 1, not attempt 1 and then attempt 2.
Expected behavior
When you upload a file as a comment it is attached to the most recent attempt, not attempt 1 always
Environment information
-
Python version (
python --version
) -
[@spruce ~]$ python --version Python 3.9.16
-
CanvasAPI version (
pip show canvasapi
) -
[@spruce ~]$ pip show canvasapi Name: canvasapi Version: 3.1.0 Summary: API wrapper for the Canvas LMS Home-page: https://github.com/ucfopen/canvasapi Author: University of Central Florida - Center for Distributed Learning Author-email: [email protected] License: MIT License Location: /home/staff/dmcphers/.local/lib/python3.9/site-packages Requires: arrow, pytz, requests Required-by:
Additional context
I already know how to fix this. Line 180 change it from this:
self.edit(comment={"file_ids": [response[1]["id"]]})
Line 180 change it to this:
self.edit(comment={"file_ids": [response[1]["id"]], "attempt": self.attempt})