canvasapi icon indicating copy to clipboard operation
canvasapi copied to clipboard

Published 20 hours ago • verified publisher icon ucfopen

Issue/363 type hints

Open bennettscience opened this issue 5 years ago • 1 comments

Proposed Changes

Include type hints for the <Canvas> class.

This is a first draft of including type annotations in the library. The contribution guidelines have also been updated to show how to add annotations to other modules following Python 3.6 formatting for backwards compatibility. I've tagged the original issue for reference, but this PR only includes annotations for <Canvas> at this point.

Related issue: #363

bennettscience avatar Oct 30 '20 13:10 bennettscience

So, this failed because of the mdl check on spaces after list markers. The rule specifies 1, the contribution guidelines all use 3. Do you want to reformat for the standard rule or write our own for 3 spaces after a list marker?

bennettscience avatar Oct 30 '20 14:10 bennettscience