canvasapi icon indicating copy to clipboard operation
canvasapi copied to clipboard

Update precommit to run other code quality scripts

Open jessemcbride opened this issue 4 years ago • 2 comments

Right now, our pre-commit-config.yaml file is only configured to run black.

precommit should run:

  • black
  • flake8
  • scripts/alphabetic.py
  • scripts/find_missing_kwargs.py

jessemcbride avatar Oct 26 '20 17:10 jessemcbride

Also isort! (assuming #438 goes through)

Thetwam avatar Nov 01 '20 03:11 Thetwam

Is it possible to pass the diffed file only to precommit? I got it working with discover on the tests directory, but couldn't limit it to the committed file only.

bennettscience avatar Nov 02 '20 20:11 bennettscience