File replace fails in Review Files

[mrash2]

When reviewing a course file in UDOIT in a Canvas course, if I drag and drop or select and upload a revised file, I receive conflicting messages. The first says the file was replaced and the second says "File failed to save locally. Please contact an administrator." The second message seems accurate because the file did not get replaced. So it seems we've run into an issue with both the conflicting messaging here and, more importantly, that the files aren't being updated.

The particular files in question are PDFs and I have not tried other file formats. I thought it might be an issue with scopes but verified that all the correct scopes are in place.

Thanks in advance!

[cidilabs]

I'm guessing this is a file permissions issue. Verify that your temp directory is set in .env, the directory exists, and has write permissions by PHP.

But we shouldn't be displaying conflicting messages to the user. We need to add a check that no error messages have been added before we add the success message

[mrash2]

Thanks all! The lack of temp directory was the problem, so all is well with this issue except the conflicting messages.

[rob-3]

This issue should be pretty easy to address. Whoever ends up taking this should look at src/Controller/FileItemsController.php and src/Services/LmsPostService.php. The issue is that FileItemsController doesn't check to see if the upload succeeded or not and LmsPostService doesn't really signal whether it worked either.