Obojobo icon indicating copy to clipboard operation
Obojobo copied to clipboard

issue/2026 Fixing Youtube Video Margins

Open RachelDau opened this issue 2 years ago • 5 comments

Added two CSS styles in viewer-component that reverse the applied margin styles to YouTube videos placed in Explanation and Feedback portions of the assessment chuck. This will stop the videos from being off center.

RachelDau avatar Sep 26 '22 20:09 RachelDau

I notice that the text in the explanation also has extra negative margin on the left. Screen Shot 2022-10-12 at 9 36 56 AM Screen Shot 2022-10-12 at 9 37 15 AM

Should both be adjusted to fit within the explanation box?

RachelDau avatar Oct 12 '22 13:10 RachelDau

I suspect the text nodes have the negative margin to mitigate some kind of baseline padding so they align better along the left side of the container. Unless you find some scenario where the text actually escapes the left boundary, I'd leave it alone for now.

FrenjaminBanklin avatar Oct 12 '22 13:10 FrenjaminBanklin

image Videos embedded in the question option body are uncentered, but is this ok or should it be adjusted?

RachelDau avatar Nov 07 '22 17:11 RachelDau

The right border doesn't extend past the parent container so it's not -too- bad, but it would look better if it was centered properly.

Feel free to take a look, just be careful if the rule that's pushing the video off-center is also factored into the appearance of other things.

FrenjaminBanklin avatar Nov 07 '22 17:11 FrenjaminBanklin

Alright. Thank you. If you get a chance can you check out numeric questions feedback section videos because they appear to be centered on my end. I checked in firefox, chrome, and safari. Let me know if it still there and if you have any tips to reproduce the issue for me to look into.

RachelDau avatar Nov 07 '22 18:11 RachelDau