snapcraft-desktop-helpers icon indicating copy to clipboard operation
snapcraft-desktop-helpers copied to clipboard

Introducing Travis CI and pre-commit framework to check shell scripts

Open brlin-tw opened this issue 7 years ago • 3 comments

brlin-tw avatar May 19 '18 10:05 brlin-tw

Thanks for your work on this!

If we are going to merge this, we should create a dedicated travis-ci account for snapcraft-desktop-helpers, or maybe re-use an existing one used by other ubuntu projects (is there one?).

I'm not familiar with pre-commit, do we really need this framework to just run shellcheck on the shell scripts? Or do you envision that there are other useful existing pre-commit hooks that we could add to the CI logic in the future?

oSoMoN avatar May 29 '18 16:05 oSoMoN

Oops I did not notice that the badge is actually bound with my forked repo, I've dropped the badge commit.

brlin-tw avatar May 29 '18 16:05 brlin-tw

do we really need this framework to just run shellcheck on the shell scripts?

I once used manually crafted scripts to check the bash scripts, but pre-commit surpasses all my expectations so recently I dropped all of them in favor of pre-commit.

Or do you envision that there are other useful existing pre-commit hooks that we could add to the CI logic in the future?

Please check out the Supported Hooks, I'm sure there are many hooks we can use with the project.

brlin-tw avatar May 29 '18 17:05 brlin-tw