gnome-shell-extension-appindicator icon indicating copy to clipboard operation
gnome-shell-extension-appindicator copied to clipboard

gnome 48 support

Open thankjura opened this issue 9 months ago • 34 comments
trafficstars

https://gjs.guide/extensions/upgrading/gnome-shell-48.html#clutter-image

thankjura avatar Feb 10 '25 18:02 thankjura

I confirm that with this patch, the appindicator extension works in both Debian Trixie with GNOME Shell 47 and Ubuntu 25.04 with GNOME Shell 48 Beta.

jbicha avatar Feb 13 '25 18:02 jbicha

i can confirm this does work in Gnome 48 rc and has no issues

ryzendew avatar Mar 05 '25 00:03 ryzendew

Hi,

Patch ok under Ubuntu 25.04 GS 48. Thanks.

galen1423 avatar Mar 09 '25 15:03 galen1423

I can confirm it works under Debian Trixie with Shell 48 Beta/RC.

mauromarinoni avatar Mar 16 '25 13:03 mauromarinoni

Can confirm working with Gnome 48 on OpenSUSE TW (Wayland). Thanks for the patch! Really helps.

hurui200320 avatar Mar 20 '25 11:03 hurui200320

It worked on Arch Linux with GNOME 48 (Wayland). Thanks.

henriqueffc avatar Mar 20 '25 15:03 henriqueffc

Worked on Fedora 42 with GNOME 48.rc (Wayland). Grateful for this.

Yarpopcat08 avatar Mar 21 '25 19:03 Yarpopcat08

Works on Arch Linux with Gnome 48. Big Thanks.

Jai-JAP avatar Mar 23 '25 09:03 Jai-JAP

Works on arch linux gnome 48 wayland

emiltoacs avatar Mar 24 '25 10:03 emiltoacs

Adding @3v1n0, he has, as far I have seen, review/merge rights...

mmattel avatar Mar 25 '25 15:03 mmattel

Works on EndeavourOS GNOME 48 with Wayland.

matheusgeres avatar Mar 25 '25 23:03 matheusgeres

Seems to work.

But, surprisingly Config.PACKAGE_VERSION never gets referenced anywhere else in the code base but in versionCheck despite multiple breaking changes in the past.

I wonder if this is the way to handle API changes in the project up until this point.

midnight-wonderer avatar Mar 26 '25 11:03 midnight-wonderer

ty, now work again :)

SalvatoreNoschese avatar Mar 28 '25 20:03 SalvatoreNoschese

image I found some of the apps still cannot show the icon,could developer fix it?Thanks!

LFRon avatar Mar 29 '25 06:03 LFRon

Don't think thats related, probably the app is doing something wrong

razzeee avatar Mar 29 '25 14:03 razzeee

Don't think thats related, probably the app is doing something wrong

But which could show on GNOME 47 with this extension,I don't know why,maybe the icon size to "0"?

LFRon avatar Mar 30 '25 14:03 LFRon

Don't think thats related, probably the app is doing something wrong

But which could show on GNOME 47 with this extension,I don't know why,maybe the icon size to "0"?

Name the app, state how you installed it. Packaging might be relevant here.

razzeee avatar Mar 30 '25 15:03 razzeee

@LFRon From my experience, I have the same bug with the telegram app. But after upgrading my kde version to the latest one (Arch btw) it solved the issue. Is your app also an kde app ?

vnghia avatar Mar 30 '25 15:03 vnghia

@LFRon From my experience, I have the same bug with the telegram app. But after upgrading my kde version to the latest one (Arch btw) it solved the issue. Is your app also an kde app ?

No,these apps with problems are Electron

LFRon avatar Mar 30 '25 15:03 LFRon

How are they packaged?

razzeee avatar Mar 30 '25 20:03 razzeee

How are they packaged?

I install the rpm/deb which have the problem.

LFRon avatar Mar 31 '25 07:03 LFRon

Which app is affected and where are the packages from? Did you really test deb and RPM on different os installs?

razzeee avatar Mar 31 '25 15:03 razzeee

Which app is affected and where are the packages from? Did you really test deb and RPM on different os installs?

I tested it yesterday,which is the app problem itself,I use newset DEB/RPM or Flatpak package like LinuxQQ performs good with this extension😭

LFRon avatar Apr 01 '25 02:04 LFRon

I don't get what you're saying, usually this happens, when the appid used does not match the apps id.

The flatpak seems to miss that, as they are not patching their app id like for e.g. https://github.com/flathub/im.riot.Riot/blob/master/im.riot.Riot.yaml#L61 does. That's electron specific.

razzeee avatar Apr 01 '25 06:04 razzeee

We, at this point, know that this patch works for the majority, but there is no need to rush.

Perhaps you followed the installation instruction on the README and want this PR merged sooner than later so you can track the version on the Gnome Extension store. (?)

The workaround

If that is the case, one could also simply keep the version compatible with Gnome 47 and use a text editor to apply the change directly to the files installed from the store. This way, the typical update flow would supposedly still work.

I won't say that ones who approve the PR just because the patch is working for them are wrong, but want to point out that it creates some noise for people who need to actually look at the code and understand things as a whole.
Maybe the proper way to handle the API changes in this project is to simply bump the supported versions in the metadata.json.

TL;DR

  • Approval is for code review; just thumbs up on a couple of the first posts are enough to show that it is working for you.
    Just because the patch is working doesn't mean it should get merged, as is.
  • I do not intend to offend people who approved the PR; just pointing out the difference in contexts.
  • We(?) can wait for both the maintainers and the author who created the PR; take your time, and ensure the extension is well maintained.

midnight-wonderer avatar Apr 01 '25 14:04 midnight-wonderer

Fedora users, uninstall the extension from Extension Manager and do this instead:

sudo dnf install gnome-shell-extension-appindicator

It's maintained by Fedora. They have already merged this patch and have it working for GNOME 48 / Fedora 42.

https://packages.fedoraproject.org/pkgs/gnome-shell-extension-appindicator/gnome-shell-extension-appindicator/

https://src.fedoraproject.org/rpms/gnome-shell-extension-appindicator/tree/rawhide

There's also another popular extension that Fedora users should get directly from Fedora instead:

sudo dnf install gnome-shell-extension-dash-to-dock

They've done a great job maintaining that for years to ensure it automatically works with each new Fedora version.

These are packages that a lot of people rely on, so you can be sure that Fedora maintains them both very well.

Arcitec avatar Apr 06 '25 23:04 Arcitec

Please merge this PR! All gnome shell 48 users need this!

mrmmg avatar Apr 07 '25 19:04 mrmmg

Please merge this PR! All gnome shell 48 users need this!

Do the workaround that @midnight-wonderer wrote in the post above. It works without any issue. Done it like that multiple times.

f0xb17 avatar Apr 07 '25 19:04 f0xb17

Fedora users, uninstall the extension from Extension Manager and do this instead:

sudo dnf install gnome-shell-extension-appindicator

It's maintained by Fedora. They have already merged this patch and have it working for GNOME 48 / Fedora 42.

https://packages.fedoraproject.org/pkgs/gnome-shell-extension-appindicator/gnome-shell-extension-appindicator/

https://src.fedoraproject.org/rpms/gnome-shell-extension-appindicator/tree/rawhide

There's also another popular extension that Fedora users should get directly from Fedora instead:

sudo dnf install gnome-shell-extension-dash-to-dock

They've done a great job maintaining that for years to ensure it automatically works with each new Fedora version.

These are packages that a lot of people rely on, so you can be sure that Fedora maintains them both very well.

@Arcitec Appindicator icons not showing and getting following issue on Fedora 42 (refer: gnome-shell-extension-appindicator - Fedora Packages)

$ sudo dnf install -y gnome-shell-extension-appindicator
Updating and loading repositories:
Repositories loaded.
Package "gnome-shell-extension-appindicator-59-4.fc42.noarch" is already installed.

Nothing to do.
$ gnome-extensions enable [email protected]
Extension “[email protected]” does not exist
$ gnome-extensions list | sort
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
emoji-copy@felipeftn
[email protected]
[email protected]
[email protected]
hibernate-status@dromi
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
tiling-assistant@leleat-on-github
[email protected]
[email protected]
[email protected]

lamyergeier avatar Apr 18 '25 04:04 lamyergeier

@lamyergeier

Did you restart your gnome-shell, if you happen to be on X11? (ALT + F2 and then using the r command?)

Aside from that you might find some of the information from my https://github.com/ubuntu/gnome-shell-extension-appindicator/issues/573#issuecomment-2763352700 useful.

You could at least go and check for the files manually to see what's actually installed, if dnf claims so.

If you find an existing installation somewhere, you could take a look at it's metadata.json file and see if it contains "48" in the "shell-version" array already. (Just as an indicator - there were more necessary changes in the appIndicator.js as you can see in the PR.)

If you can provide some more info, we might be able to help more easily.

Edit: fixed link to the wrong comment

philg-dev avatar Apr 18 '25 07:04 philg-dev