gnome-shell-extension-appindicator icon indicating copy to clipboard operation
gnome-shell-extension-appindicator copied to clipboard

Fix this._watchDog can be undefined

Open QuentiumYT opened this issue 2 years ago • 5 comments

Having the issue sometimes since I installed it, I found that when deactivating and reactivating cause the extension to crash with this._watchDog is undefined. Just check if this._watchDog is set before accessing its values

QuentiumYT avatar Nov 08 '23 13:11 QuentiumYT

Do you have a JS trace in the case of this._watchDog being undefined?

3v1n0 avatar Nov 21 '23 17:11 3v1n0

Do you have a JS trace in the case of this._watchDog being undefined?

Actually no, but I can rebuilt it from main and send it. As I remember, it was triggered on disable / reenable and a few other cases. But there wasn't a lot of details in the error

QuentiumYT avatar Nov 21 '23 17:11 QuentiumYT

Done, do you want me to still send the JS error log?

QuentiumYT avatar Nov 22 '23 10:11 QuentiumYT

I'd be curious, to see if we can figure out also the root reason for this.

3v1n0 avatar Nov 22 '23 19:11 3v1n0

I wasn't able to reproduce, very strange. I might have a clue, I have 4 sessions for the desktop environment:

  • Ubuntu on xorg
  • Ubuntu on wayland
  • Gnome on xorg
  • Gnome on wayland

And one day, it switched but I did nothing. It broke almost all extensions (unable to activate them) and this error was thrown when enabling this extension.

I should mention as well that I build glib from source which might lead to some issues. Because I know gio is a bit broken on my laptop (btw if you have enough knowledge to exchange about that ^^) but seems to work fine after I changed a whole number of things

PS: yeah I know, I like to play with fire building a lot of things from source haha, but I enjoy doing that :)

QuentiumYT avatar Nov 22 '23 20:11 QuentiumYT