gnome-shell-extension-appindicator icon indicating copy to clipboard operation
gnome-shell-extension-appindicator copied to clipboard

Lags on unlock only when the extension is enabled

Open KotoWhiskas opened this issue 4 years ago • 7 comments

When I enable this extension, if I lock screen, the lock animation runs smoothly, and when unlocking, lags appear and the animation runs at ~ 5 fps. Also, this problem is not present in "Tray Icons: Reloaded" extension.

Happens on all gnome shell versions from 3.36 to 40.3 on all distros (2k monitor, amd rx470, intel core i7 10700)

KotoWhiskas avatar Aug 04 '21 10:08 KotoWhiskas

All gnome-style top icons generate constant fps drops, destroying the desktop experience especially in games.

But more legacy top icon like https://extensions.gnome.org/extension/2890/tray-icons-reloaded/ works without affecting performance

Gnome 3.38.4, Zorin 16, Kernel 5.11.0-34-generic AMD Ryzen 3 3100 4-Core AMD Radeon RX 580 Series

JumperLuko avatar Sep 09 '21 02:09 JumperLuko

@JumperLuko such extension is only supporting legacy tray icons, which are quite simpler for the shell compared to the appindicators.

Mostly because appindicators require quite a lot of dbus chatting and include menus (that are quite slow to puplate in gnome shell).

I may see if using some lazy re-enabling of the extension may help with this.

3v1n0 avatar Sep 27 '21 20:09 3v1n0

Still experiencing this issue with unlock lag. Just out of curiosity; can we expect some optimisations here or is the current situation as good as it gets?

mvolf avatar Jan 24 '22 15:01 mvolf

Some improvements are included in #402 and #405, all the rest of operations are now async, so most we could do should be handled now.

Maybe delaying the whole extension enabling could improve it even further, but I'd prefer to avoid that.

3v1n0 avatar Mar 03 '23 01:03 3v1n0

Also experiencing this with dash-to-dock enabled. May be related to a similar case?

emansom avatar Mar 10 '23 10:03 emansom

I've been checking this again, and indeed we've some code that, even if that's fully async, it causes lagging.

While there's stuff (like the menu-items initialization) that is basically impossible to fix unless we split that into multiple chunked requests in different main loop idles, but that's something that increases a bit the complexity...), there are other parts that we can optimize or either move to be handled by another off-process script.

3v1n0 avatar Mar 13 '23 16:03 3v1n0

Ok, I've prepared #417 that seems to improve the situation, I've also further ideas, but let's see first with this.

3v1n0 avatar Mar 13 '23 18:03 3v1n0