ubuntu
ci/build-deb: Don't merge main
When building Debian packages from the branch of a PR, we want to actually build what's on the branch, without changes from main.
That's especially important when preparing bugfix releases, which we build from the source packages from the CI. We don't want unexpected changes from main to end up in these releases.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.65%. Comparing base (
1236577) to head (3572c6d). Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #987 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 82 82
Lines 5794 5794
Branches 111 111
=======================================
Hits 4963 4963
Misses 775 775
Partials 56 56
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Seems to work https://github.com/ubuntu/authd/actions/runs/15733678611/job/44340683750?pr=987#step:2:85
do you agree that we still want this PR, even though for releases we can use the artifacts built from the tag? my reasoning is that it's still unexpected that the debian packages built for a PR contain changes from main which are not in the PR branch.
Well, there are pro and cons... Like in this way we can test what would be once merged, otherwise it's also true that one can just rebase... So indeed this gives more freedom of choice.
