app-center icon indicating copy to clipboard operation
app-center copied to clipboard

Carousel image dialog padding is not consistent

Open Jupi007 opened this issue 3 years ago • 2 comments

The dialog is using material default padding which is EdgeInsets.fromLTRB(0.0, 12.0, 0.0, 16.0), and it looks weird:

image

Imo, we should either remove the padding:

Capture d’écran du 2022-09-21 22-59-18

Or add the same one for each edge:

Capture d’écran du 2022-09-21 22-59-33

Sorry, I don't know why, but I can't load any image in the app

CC @Feichtmeier

Jupi007 avatar Sep 21 '22 21:09 Jupi007

snap store is currently in maintenance

I mean the backend :) Sleep well 😴

Feichtmeier avatar Sep 21 '22 21:09 Feichtmeier

Oh, okay. I was thinking it was my internet connexion which was completely broken 😅

Sleep well 🌜

Jupi007 avatar Sep 21 '22 21:09 Jupi007

@Jupi007 I think this is fixed? Or maybe I did not understand it correctly

grafik

Feichtmeier avatar Nov 18 '22 13:11 Feichtmeier

The look has changed since my first message but I think it is still the same problem :)

Imo, this dialog should look like this:

image

  • No titlebar, just the close button ;
  • same padding on top, bottom and around the close button ;
  • same margin as padding on top of the carousel place indicator.

I created a branch if you want to test: Jupi007/issue253

Jupi007 avatar Nov 19 '22 09:11 Jupi007

Thanks! Feel free to create a pull request

Or should we add a border property to the titleBar first?

Feichtmeier avatar Nov 19 '22 11:11 Feichtmeier

Or should we add a border property to the titleBar first?

I think we can, but it is not necessary for this as we just want a close button :)

Thanks! Feel free to create a pull request

Okay 🚀

Jupi007 avatar Nov 19 '22 11:11 Jupi007