app-center icon indicating copy to clipboard operation
app-center copied to clipboard

chore: Format time since last update as days, months or years

Open krille-chan opened this issue 1 year ago โ€ข 5 comments

Hi there โœŒ๏ธ I'm a huge fan of the new app center. Thank you very much for developing. Maybe I can contribute a little bit?

The time since the last update is only displayed in days right now, while it could be nice to also have it in months and years.

I was not sure where to put the logic for the formatted string calculation. If you know a better place like a /utils directory that I might have overseen, please ping me and I will change it.

Bildschirmfoto vom 2024-03-29 08-59-35

krille-chan avatar Mar 29 '24 08:03 krille-chan

Everyone contributing to this PR have now signed the CLA. Thanks!

github-actions[bot] avatar Mar 29 '24 08:03 github-actions[bot]

I have signed the CLA but it still doesn't seem to find my github account krille-chan nor does it find the email address I used to sign the CLA. I made sure that this email address is the same i used for launchpad and for the CLA sign form

krille-chan avatar Mar 29 '24 08:03 krille-chan

Thanks @krille-chan for your contribution! ๐Ÿ˜ƒ (also also thank you for fluffy-chat, awesome application)!

Sometimes this test needs some time to find your updated user name/email.

@d-loose is this test still needed? I saw some discussions about removing it, considering this is an open source project using GPL3, I don't really understand why it is there at all (really curious, no criticism)?

Feichtmeier avatar Apr 03 '24 15:04 Feichtmeier

I have signed the CLA but it still doesn't seem to find my github account krille-chan nor does it find the email address I used to sign the CLA. I made sure that this email address is the same i used for launchpad and for the CLA sign form

Hm, from what I can tell you're not a member of https://launchpad.net/~contributor-agreement-canonical. But we've had some issues with the CLA in the past, I'll have another look.

@d-loose is this test still needed? I saw some discussions about removing it, considering this is an open source project using GPL3, I don't really understand why it is there at all (really curious, no criticism)?

I'll bring it up on Monday when Tim is back, since I'm not sure how that works exactly, especially since app-center is in the ubuntu organization and not in canonical.

d-loose avatar Apr 04 '24 10:04 d-loose

I have signed the CLA but it still doesn't seem to find my github account krille-chan nor does it find the email address I used to sign the CLA. I made sure that this email address is the same i used for launchpad and for the CLA sign form

Hm, from what I can tell you're not a member of https://launchpad.net/~contributor-agreement-canonical. But we've had some issues with the CLA in the past, I'll have another look.

@d-loose is this test still needed? I saw some discussions about removing it, considering this is an open source project using GPL3, I don't really understand why it is there at all (really curious, no criticism)?

I'll bring it up on Monday when Tim is back, since I'm not sure how that works exactly, especially since app-center is in the ubuntu organization and not in canonical.

Hm, I have now filled out this form https://ubuntu.com/legal/contributors/agreement multiple times now (while not sure what to put at "Please add the Canonical Project Manager or contact") is there anything else I can do?

krille-chan avatar Apr 04 '24 17:04 krille-chan

Hm, I have now filled out this form https://ubuntu.com/legal/contributors/agreement multiple times now (while not sure what to put at "Please add the Canonical Project Manager or contact") is there anything else I can do?

Sorry, we haven't forgotten about you! Apparently there are some issues with the CLA action that need to be sorted out. Currently the upcoming release is taking up a lot of everyone's time though. I hope it's ok if we get back to you in a few weeks once the LTS is out. We definitely want to spend more time on the App Center again next cycle and are happy about all the community contributions we can get!

d-loose avatar Apr 10 '24 15:04 d-loose

Hm, I have now filled out this form https://ubuntu.com/legal/contributors/agreement multiple times now (while not sure what to put at "Please add the Canonical Project Manager or contact") is there anything else I can do?

Sorry, we haven't forgotten about you! Apparently there are some issues with the CLA action that need to be sorted out. Currently the upcoming release is taking up a lot of everyone's time though. I hope it's ok if we get back to you in a few weeks once the LTS is out. We definitely want to spend more time on the App Center again next cycle and are happy about all the community contributions we can get!

Sure that is okay. Thank you so much and ping me at any time about this :)

krille-chan avatar Apr 11 '24 08:04 krille-chan

The CLA check issue has been resolved now :). I've left a small comment regarding code organization.

d-loose avatar Apr 17 '24 16:04 d-loose