app-center icon indicating copy to clipboard operation
app-center copied to clipboard

Published 20 hours ago • verified publisher icon ubuntu

Track active changes in the application and show list in manage page.

Open codinesh opened this issue 1 year ago • 9 comments

Fixes https://github.com/ubuntu/app-center/issues/1438, by displaying a section for installing/uninstalling snaps.

image

To Listen to the changes from Snap details page, tapped on to SnapModel._activeChangeListener to know the installs, uninstalls and change updates. This will call the ManageModel to maintain the list of active snaps. Scope of this change to track the changes made from this app, as a workaround to an issue in /v2/changes api, which doesn't give enough information to identify corresponding snap from the response.

Workaround is discussed https://github.com/ubuntu/app-center/issues/1438#issuecomment-1833651474.

Here is link to accidentally closed original PR with some discussions. Current PR is created with code changes from original PR.

codinesh avatar Dec 15 '23 16:12 codinesh

Requesting @d-loose, @BLKKKBVSIK and @anasereijo to review this PR instead of #1517.

Thanks for understanding.

codinesh avatar Dec 15 '23 16:12 codinesh

Everyone contributing to this PR have now signed the CLA. Thanks!

github-actions[bot] avatar Dec 20 '23 16:12 github-actions[bot]

LGTM ! Let's just wait until @anasereijo comes back from holidays to see if the UI changes are approuved :)

BLKKKBVSIK avatar Dec 29 '23 10:12 BLKKKBVSIK

Sounds good, thanks.

codinesh avatar Dec 29 '23 14:12 codinesh

Great work @codinesh! Just a few points:

  • when there are no apps being installed, this section will be hidden, correct?
  • would be nice to display the option to cancel the installation
  • maybe we can remove the more options button [ ... ] since it's probably not very useful or no actions to be taken while the installation is in progress

did a quick mock-up of how it could look like:

Screenshot 2024-01-02 at 16 03 20

Thank you

anasereijo avatar Jan 02 '24 16:01 anasereijo

Great work @codinesh! Just a few points:

  • when there are no apps being installed, this section will be hidden, correct?

Yes, that is the behavior..

Thanks for suggestions on additional options and the Cancel button, will take up these changes.

Will match figma. Thank you.

codinesh avatar Jan 02 '24 16:01 codinesh

Hello @anasereijo,

maybe we can remove the more options button [ ... ] since it's probably not very useful or no actions to be taken while the installation is in progress

Should we keep the [...] options button to make it consistent with other two sections. Please see the screenshot. Since the item is to open, will be navigated to snap detail page.

Please let me know what you thing, change is simple in any case.

Screenshot from 2024-01-03 19-42-23

Thank you

codinesh avatar Jan 03 '24 14:01 codinesh

Hello @anasereijo,

maybe we can remove the more options button [ ... ] since it's probably not very useful or no actions to be taken while the installation is in progress

Should we keep the [...] options button to make it consistent with other two sections. Please see the screenshot. Since the item is to open, will be navigated to snap detail page.

Please let me know what you thing, change is simple in any case.

Screenshot from 2024-01-03 19-42-23

Thank you

Hi @anasereijo please have a look at this comment and share your opinion.

codinesh avatar Jan 20 '24 17:01 codinesh

Hi @codinesh, apologies for my late reply.

Good catch! we should keep consistency with the other sections indeed. so lets keep the button [ ... ] whilst the snap is installing.

thank you!

anasereijo avatar Jan 22 '24 10:01 anasereijo