app-center icon indicating copy to clipboard operation
app-center copied to clipboard

feat: adding shimmer when the ratings are loading.

Open BLKKKBVSIK opened this issue 1 year ago • 4 comments

In this PR:

  • Adding shimmers placeholder text during the loading of the ratings.

fix #1447

Screencast from 2023-12-12 11-54-14.webm

BLKKKBVSIK avatar Dec 12 '23 11:12 BLKKKBVSIK

Could we just have the whole page loading using a skeleton loader?

anasereijo avatar Dec 12 '23 16:12 anasereijo

Could we just have the whole page loading using a skeleton loader?

Except for the ratings, there is nothing that needs loading on the package page. If the styling of the shimmer effect is a no-go, I can update it.

BLKKKBVSIK avatar Dec 13 '23 09:12 BLKKKBVSIK

@BLKKKBVSIK, I think it looks odd using the skeleton (shimmer) just on the ratings, as it's only loading a tiny fraction of the screen. I think we should force the whole section to be skeleton until everything in there is ready to be loaded (in this case, ratings). It's more perceptive that it's loading information, and the order we want users to read the content is kept (ratings first)

Screenshot 2023-12-13 at 14 29 28

anasereijo avatar Dec 13 '23 14:12 anasereijo

However, all the other information is available immediately and doesn't need any loading indicator. It'd be a shame if we had to add a skeleton loader just because of the ratings :cry:

d-loose avatar Dec 15 '23 11:12 d-loose