app-center icon indicating copy to clipboard operation
app-center copied to clipboard

'Change channel' shown in 2 lines

Open fthx opened this issue 1 year ago โ€ข 10 comments

Hi,

image

Could be better in 1 line only, FR version here.

fthx avatar Nov 29 '23 15:11 fthx

Hi @fthx, thanks for reporting this!

Feels like instead of doing a text wrap and spanning it over two lines we should swap to cutting off lines with an ellipsis if we run out of screen space. (ie: Changer de can...) @anasereijo?

matthew-hagemann avatar Nov 30 '23 09:11 matthew-hagemann

Ellipsis does not look great, IMO. image Here we have some place for a longer string, because reducing the width shows another layout: image where there is a lot of place for change-channel string.

fthx avatar Nov 30 '23 10:11 fthx

Can we resize the button according to the text length?

anasereijo avatar Nov 30 '23 16:11 anasereijo

Can we resize the button according to the text length?

We can, but on long text, it will break the UI on the smallest breakpoint. Or we can cut the text off with an ellipsis only on the smallest breakpoint.

BLKKKBVSIK avatar Dec 11 '23 15:12 BLKKKBVSIK

Or we can cut the text off with an ellipsis only on the smallest breakpoint.

That sounds good! I suppose there will be a tooltip on hover to tell the user the full label?

anasereijo avatar Dec 11 '23 19:12 anasereijo

Means that the label will not be fully displayed? Sorry, I don't understand this regression here.

fthx avatar Dec 11 '23 19:12 fthx

Means that the label will not be fully displayed? Sorry, I don't understand this regression here.

The label will try to be displayed fully, but depending on the window size, there might be an ellipsis with a tooltip.

BLKKKBVSIK avatar Dec 12 '23 09:12 BLKKKBVSIK

Ok. But the point I do not understand is that when the window's width is low, the "Change channel" label comes above the main info row. image So it seems there's not really a label's width issue?

fthx avatar Dec 12 '23 09:12 fthx

I don' t understand the eyes.

In fact, there is a wider probleme IMO here: image There are two labels (package, channel/open) those widths are not dynamically set and there is a lot of space left to not ellipsize any of them.

fthx avatar Dec 18 '23 07:12 fthx

The eye emoji means that we will look into this. I agree with you, the buttons with should depend on the length of their text.

BLKKKBVSIK avatar Dec 18 '23 08:12 BLKKKBVSIK