app-center icon indicating copy to clipboard operation
app-center copied to clipboard

Replacing some dependencies from git to their pub.dev version

Open guyluz11 opened this issue 3 years ago โ€ข 1 comments

Closes #146

guyluz11 avatar Sep 01 '22 08:09 guyluz11

yaru_icons and yaru_widgets do not have last version in pub.dev and it causes some error when trying to use pub.dev version.

yaru_widgets error:

ERROR: lib/store_app/updates/updates_page.dart:364:17: Error: The method 'YaruAnimatedOkIcon' isn't defined for the class '_NoUpdatesPage'.
ERROR:  - '_NoUpdatesPage' is from 'package:software/store_app/updates/updates_page.dart' ('lib/store_app/updates/updates_page.dart').
ERROR: Try correcting the name to the name of an existing method, or defining a method named 'YaruAnimatedOkIcon'.
ERROR:                 YaruAnimatedOkIcon(
ERROR:                 ^^^^^^^^^^^^^^^^^^
ERROR: lib/store_app/updates/update_banner.dart:45:11: Error: No named parameter with the name 'bannerWidth'.
ERROR:           bannerWidth: 500,
ERROR:           ^^^^^^^^^^^
ERROR: ../../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/yaru_widgets-1.1.1/lib/src/yaru_banner.dart:6:9: Context: Found this candidate, but the arguments don't match.
ERROR:   const YaruBanner({
ERROR:         ^^^^^^^^^^
Exception: Build process failed

So I didn't changed them

guyluz11 avatar Sep 01 '22 08:09 guyluz11

@guyluz11 I just published yaru_widgets.dart v1.1.2 and yaru_icons.dart v0.2.2. So you can use them in this PR :)

Jupi007 avatar Sep 03 '22 13:09 Jupi007

Everyone contributing to this PR have now signed the CLA. Thanks!

github-actions[bot] avatar Sep 04 '22 10:09 github-actions[bot]

yaru_icons and yaru_widgets do not have last version in pub.dev and it causes some error when trying to use pub.dev version.

yaru_widgets error:

ERROR: lib/store_app/updates/updates_page.dart:364:17: Error: The method 'YaruAnimatedOkIcon' isn't defined for the class '_NoUpdatesPage'.
ERROR:  - '_NoUpdatesPage' is from 'package:software/store_app/updates/updates_page.dart' ('lib/store_app/updates/updates_page.dart').
ERROR: Try correcting the name to the name of an existing method, or defining a method named 'YaruAnimatedOkIcon'.
ERROR:                 YaruAnimatedOkIcon(
ERROR:                 ^^^^^^^^^^^^^^^^^^
ERROR: lib/store_app/updates/update_banner.dart:45:11: Error: No named parameter with the name 'bannerWidth'.
ERROR:           bannerWidth: 500,
ERROR:           ^^^^^^^^^^^
ERROR: ../../../../snap/flutter/common/flutter/.pub-cache/hosted/pub.dartlang.org/yaru_widgets-1.1.1/lib/src/yaru_banner.dart:6:9: Context: Found this candidate, but the arguments don't match.
ERROR:   const YaruBanner({
ERROR:         ^^^^^^^^^^
Exception: Build process failed

So I didn't changed them

@Jupi007 after pulling from master I still getting the error with packages version yaru_icons: ^0.2.2 yaru_widgets: ^1.1.1

guyluz11 avatar Sep 04 '22 10:09 guyluz11

Indeed, please use yaru_widgets: ^1.1.2. I'm really sorry, I was sure I had uploaded it yesterday ๐Ÿค•

Jupi007 avatar Sep 04 '22 10:09 Jupi007

You need to sign the contributor agreement in order to let the first test pass :) https://ubuntu.com/legal/contributors/agreement If you agree make sure to take the exact mail address this commit is made with

Feichtmeier avatar Sep 04 '22 10:09 Feichtmeier

You need to sign the contributor agreement in order to let the first test pass :) https://ubuntu.com/legal/contributors/agreement If you agree make sure to take the exact mail address this commit is made with

Done

guyluz11 avatar Sep 04 '22 22:09 guyluz11