ubports-installer icon indicating copy to clipboard operation
ubports-installer copied to clipboard

Fix device model auto-detection for UT devices running Halium (11) GSI

Open JamiKettunen opened this issue 2 years ago • 1 comments

With the Volla Phone 22 I noticed the UBports installer cannot detect the device with Ubuntu Touch already booted image It detects the device as halium_arm64 which just happens to match ro.product.device property and used to be an ok way to detect the device, however ro.product.vendor.device should be considered as well to catch devices using the Halium 11 GSI for example

$ adb shell getprop ro.product.device
halium_arm64
$ adb shell getprop ro.product.vendor.device
mimameid

Is this how we should fix the problem or should something else be done?

The UT Samsung Galaxy S7 port currently uses this ugly hack to get the installer to recognize it with Ubuntu Touch already booted.

JamiKettunen avatar Sep 23 '22 21:09 JamiKettunen

The GSI should set ro.product.property_source_order to prioritize reading properties from vendor when applying to ro.product.* properties.

For example:

ro.product.property_source_order=vendor,odm,product,system_ext,system

Reference: https://chromium.googlesource.com/aosp/platform/system/core/+/refs/heads/master/init/property_service.cpp#808

amartinz avatar Sep 23 '22 21:09 amartinz