ubports-installer icon indicating copy to clipboard operation
ubports-installer copied to clipboard

Core: fix step run error logging

Open amartinz opened this issue 2 years ago • 0 comments

Eh, looks like Winston's default error object handling is just too simple. For an error that apparently kills the run, everything including the stacktrace should be printed and JSON.stringify won't work since the properties are not enumerable.

This looks like the simplest solution: https://github.com/winstonjs/winston/issues/1338#issuecomment-697958085 Would require also changing this to two log calls (also this feels more like error than debug level imo).

Originally posted by @maciek134 in https://github.com/ubports/ubports-installer/pull/2827#discussion_r964970001

amartinz avatar Sep 07 '22 15:09 amartinz