docs.ubports.com icon indicating copy to clipboard operation
docs.ubports.com copied to clipboard

Published 20 hours ago • verified publisher icon ubports

Adding System-as-root related info for H9 build

Open mathew-dennis opened this issue 2 years ago • 5 comments

adding content related to system-as-root .

mathew-dennis avatar May 04 '22 20:05 mathew-dennis

@mathew-dennis are you able to follow up the review?

doniks avatar Jul 25 '22 12:07 doniks

@mathew-dennis are you able to follow up the review?

sorry I missed @abkro 's review, added the change,please review now and thanks @abkro

mathew-dennis avatar Jul 25 '22 13:07 mathew-dennis

hey thanks for the quick followup. however, also, sorry, I found a few more points pls check

doniks avatar Jul 25 '22 13:07 doniks

@doniks done ;-)

also, could you please check with TheKit before merging, coz when I made this pr ,there was a comment in the porting group that this content is no longer relevant.thanks

mathew-dennis avatar Jul 27 '22 18:07 mathew-dennis

@doniks done ;-)

Awesome. Thanks.

also, could you please check with TheKit before merging, coz when I made this pr ,there was a comment in the porting group that this content is no longer relevant.thanks

Of course! :D @NotKit could you weigh in here?

doniks avatar Jul 27 '22 18:07 doniks

Mhm. We've been sitting on this for a while now. No feedback from notkit, but I also think this is not a very risky change. Let's merge and fix it later if needed

doniks avatar Sep 18 '22 20:09 doniks