emacs-module-rs icon indicating copy to clipboard operation
emacs-module-rs copied to clipboard

Published 20 hours ago • verified publisher icon ubolonton

Naming of method Value::make_global_ref

Open cireu opened this issue 5 years ago • 2 comments

According to https://rust-lang.github.io/api-guidelines/naming.html. I think we'd better to rename make_global_ref to to_global_ref to help user discover this API. What's your opinion?

cireu avatar Oct 28 '20 10:10 cireu

Or even into_global_ref? though Value derives Copy, but it's actually a proxy type of Emacs value, not a POD in true sense.

cireu avatar Oct 28 '20 10:10 cireu

Yeah, either to_ or into_ sounds better. I'm leaning towards the former, but I'm not sure yet.

ubolonton avatar Nov 08 '20 13:11 ubolonton