Sharpmake icon indicating copy to clipboard operation
Sharpmake copied to clipboard

Add option to force project references export

Open ShawnCZek opened this issue 3 years ago • 7 comments

Similarly to #219, I am working on sharing the precompiled header between multiple projects. To make this possible, the other projects must be exported as a reference. MSVC does otherwise not wait for the compilation to finish.

Right now, project references are not exported for static libraries. And while ExportAdditionalLibrariesEvenForStaticLib exists as a configuration option, it does more things at once, often resulting in already defined in X.lib(X.dll); second definition ignored warnings.

Therefore, this pull request adds an option to force the export of these references regardless of the output type of the project.

ShawnCZek avatar Sep 30 '22 08:09 ShawnCZek

Hi, Sorry for the lack of updates. Lambert left Ubisoft and we had to rebuild a new maintainer group.

We will take a look at this MR soon.

jspelletier avatar Mar 22 '23 13:03 jspelletier

@jspelletier is this related to https://github.com/ubisoft/Sharpmake/issues/146? it's the same config option

bchampoux avatar Mar 23 '23 15:03 bchampoux

@ShawnCZek could you add/modify some sample using this?

jspelletier avatar May 12 '23 13:05 jspelletier

@jspelletier I can take a look at trying to integrate this into existing samples. However, as pointed out earlier here, #253 basically collides with this PR. And if that one is merged, this can be closed.

ShawnCZek avatar May 20 '23 10:05 ShawnCZek

@ShawnCZek The problem with #253 is it doesn't have an explicit option and will affect our existing generated files so it won't ever be merged in its current state,

jspelletier avatar May 23 '23 12:05 jspelletier

Perfect. Thank you for the answer! In the following days, I will take a look at modifying the existing samples to integrate this change. Once that is done, I will mention you here again.

ShawnCZek avatar May 23 '23 14:05 ShawnCZek