NGitLab
NGitLab copied to clipboard
ubisoft
Ability to upload to Generic Packages Repository
@meziantou I have opened this as draft, based on the comments that you have made here:
https://github.com/ubisoft/NGitLab/discussions/511#discussioncomment-6917731
I would love to get some feedback on what I have done here, and what changes/suggestions you could make.
This is quite a naive implementation based on my own needs, and the information that I could find here:
https://docs.gitlab.com/ee/user/packages/generic_packages/index.html#do-not-allow-duplicate-generic-packages
Thanks!
I would love to get some feedback on what I have done here, and what changes/suggestions you could make.
That's a good start! I've added some comments, but the shape is ok
@meziantou I have taken a stab at making the changes that you suggested, and I have implemented a couple more methods on the new PackageClient for Get and GetByIdAsync. Let me know if you have any further questions/suggestions.
Side Question... Should I create an issue for this feature addition, or assuming that we move forward with this, are you ok to merge the PR directly, without an associated issue?
Side Question... Should I create an issue for this feature addition, or assuming that we move forward with this, are you ok to merge the PR directly, without an associated issue?
No need to create an issue
Sorry for barging in, but I was actually looking into adding support for GitLab's package registry to NGitLab myself when I saw there is already an open PR.
Is there anything I can do to complete this? I'd be happy to help out
I keep trying to get back to the PR, but I just haven't had the cycles to do it yet ☹️
From memory, all that was remaining was some re-work for the tests to not depend on file system directly.
If you have some time, I have no objections to you creating a PR into my fork, and then I can update this PR.
If you have some time, I have no objections to you creating a PR into my fork, and then I can update this PR.
Great, I'll see what I can do