weechat-android
weechat-android copied to clipboard
ubergeek42
Option for increasing/decreasing line spacing
I think it can be a little difficult or more stressful to read everything being put in same mess with short line spaces. This is possibly one reason why some "IRC alternatives" like Slack/Telegram/Discord get users from IRC and sometimes have option for "IRC mode" where everything is in one mess and their default mode is "relaxed".
Example screenshots (I don't know if my point goes across though):
- WeeChat on urxvt with
URxvt*lineSpace: 5 - WeeChat Android
- Riot
I've been wanting this for the opposite reason because Fira Code specifically has way too much line spacing with the metrics that weechat-android uses, for some reason.
https://github.com/ubergeek42/weechat-android/blob/53d38ff5b2a5d4f64720c64d1953a1bda34d78c2/app/src/main/java/com/ubergeek42/WeechatAndroid/views/AlphaLayout.kt#L62-L70
Currently there's extra spacing between messages compared to lines because the top branch here doesn't call .setIncludePad(INCLUDE_PADDING), while the old one effectively does. It seems like this is why some fonts, like Fira Code, have much more padding between messages than others. Simply fixing this makes the chat feel pretty cramped though.
I suppose including padding (which is the default) is a good thing though? Not sure why the bottom branch excludes it. If this is too much or not enough this probably should be solved by the option to increase/decrease line spacing, which this issue is about. Want to make a PR? ;)
The extra padding is between each message not each line and varies wildly between fonts though. I'll make a PR if I find a nice way to fix it and make both the line and message spacing configurable.
Ah, thanks for clarifying, that wasn't immediately clear from the doc on setIncludePad. Yeah two settings would be fine for this I think 👍