react-vis icon indicating copy to clipboard operation
react-vis copied to clipboard

Allow using Storybook for local development.

Open Xiot opened this issue 4 years ago • 2 comments

Storybook is an easy to use UI to enable testing out features. This allows storybook to pick up changes from react-vis/src so that it can be used while developing components.

Xiot avatar Jun 07 '20 01:06 Xiot

I realize that its baking in some of the external config, but it only does it for development.

Previously, the storybook, used react-vis from the node_modules, so if you wanted to make a change and see it in storybook, you had to

  1. make the change
  2. stop storybook
  3. yarn build on react-vis
  4. start up the storybook.

With this, the development cycle becomes.

  1. start storybook
  2. make a change to the component.
  3. repeat step 2.

This greatly enhances the flow.

I really like developing with storybook because of the ability to add knobs. You end up with a fairly fluid experience.

When I was digging into https://github.com/uber/react-vis/issues/1347 I actually set up a storybook as it allowed me to easily visualize and test what was going on. Unfortunately I had to follow the painful original flow of stopping, changing, building, starting

Xiot avatar Jun 07 '20 16:06 Xiot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Chris Thomas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 07 '22 12:04 CLAassistant