react-vis icon indicating copy to clipboard operation
react-vis copied to clipboard

Refactor component will receive props

Open Xiot opened this issue 4 years ago • 1 comments

Rebased https://github.com/uber/react-vis/pull/1253 and fixed up the tests.

Changes the usages of componentWillReceiveProps to componentDidUpdate. This does change up the timing a little but, which is why there is an extra update() on the tests. I've run through the storybook and everything looks like everything is still working

Xiot avatar May 31 '20 15:05 Xiot

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: DiegoGorgazzi
:x: Chris Thomas


Chris Thomas seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 07 '22 12:04 CLAassistant