react-vis icon indicating copy to clipboard operation
react-vis copied to clipboard

Published 20 hours ago • verified publisher icon uber

Refactor componentWillReceiveProps

Open DiegoGorgazzi opened this issue 5 years ago • 7 comments

Refactored componentWillReceiveProps to work with componentDidUpdate

Fixes #1084 and #1245

DiegoGorgazzi avatar Oct 18 '19 13:10 DiegoGorgazzi

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 18 '19 13:10 CLAassistant

Hey y'all when will this be merged?

cesrjimenez avatar Nov 23 '19 06:11 cesrjimenez

Hello, any update on this issue? Thanks in advance

jota12x avatar Dec 11 '19 11:12 jota12x

I also would like this to be merged. Can we get an update? Seeing an issue where the FlexibleXYPlot is not resizing properly when paired with Suspense because componentWillReceiveProps fires before the display: none !important; is removed from the suspended component, which means it sets the width and height to 0.

kanzelm3 avatar Dec 17 '19 16:12 kanzelm3

👍

gartenfeld avatar Feb 12 '20 16:02 gartenfeld

Sorry all for the terrible response time. As you may have been aware, development on react-vis was stalled for some time. We are getting back into it however, as we are focusing on modernizing it a bit and putting a focus on performance.

I've rebased and fixed some tests over this this PR (that is based on this one) https://github.com/uber/react-vis/pull/1343

Xiot avatar May 31 '20 16:05 Xiot

@Xiot Is there any update on when this can be merged? This issue is becoming more and more pressing for us! Thanks!

jrdzha avatar Nov 30 '20 19:11 jrdzha