react-vis icon indicating copy to clipboard operation
react-vis copied to clipboard

Migrate away from componentWillReceiveProps

Open havardh opened this issue 6 years ago • 8 comments

Hi. :wave:

By running in react strict-mode, I noticed that that react-vis relies on the now deprecated componentWillReciveProps.

With a quick search in the repo I found the following usages (examples are omitted):

These should be easily resolvable by moving to either getDerivedStateFromProps or componentDidUpdate or memoization as detailed here and here.

Are there any plans for doing or concerns about doing these changes?

If these changes makes sense for the project, I could make a PR for them 👍

havardh avatar Jan 10 '19 12:01 havardh

Hey that sounds like great work to be doing! I would love to see a PR to that effect

mcnuttandrew avatar Jan 10 '19 21:01 mcnuttandrew

+1

taltultc avatar Aug 15 '19 09:08 taltultc

+1

fedorov-xyz avatar Aug 26 '19 10:08 fedorov-xyz

Please fix this or the Project will soon stop working :) Im getting the warning:

Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: FlexibleXYPlot

TimoPurzner avatar Sep 04 '19 12:09 TimoPurzner

Same here please! image

testacode avatar May 22 '20 05:05 testacode

Is there any update on this?

yukoliesh avatar Aug 27 '20 23:08 yukoliesh

Just close this library if you guys are not going to maintain it well

tp00012x avatar Mar 04 '22 06:03 tp00012x