peloton icon indicating copy to clipboard operation
peloton copied to clipboard

Published 20 hours ago • verified publisher icon uber

Add intersect util method for StringSet

Open axamon opened this issue 5 years ago • 7 comments

Intersect function for *StringSet types that is concurrent safe added.

axamon avatar Apr 01 '19 09:04 axamon

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 01 '19 09:04 CLAassistant

I do not think we should add the func if there is no use case.

zhixinwen avatar Apr 01 '19 21:04 zhixinwen

I do not think we should add the func if there is no use case.

That's fine.

varungup90 avatar Apr 01 '19 23:04 varungup90

@axamon Update the commit message to be more meaningful.

varungup90 avatar Apr 01 '19 23:04 varungup90

I added the intersect function for *StringSet types that is concurrency safe.

axamon avatar Apr 02 '19 13:04 axamon

I added the intersect function for *StringSet types that is concurrency safe.

Can you change commit name from "added intersect" to something "Add intersect util method for StringSet"

As well as change commit message from "might be useful" -> relevant to the PR.

varungup90 avatar Apr 02 '19 22:04 varungup90

@axamon Thank for the fixes, we do not have unit & integration test CI setup at open source yet. I will run the patch locally, if no errors then I will merge the PR.

varungup90 avatar Apr 03 '19 17:04 varungup90