needle
needle copied to clipboard
Annotate types, generated code with @MainActor
Proof of concept to allow UIKit dependencies to exist in the DI graph with with Swift Concurrency
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
It looks like to do this we'll need to drop support for Swift < 5.5.
I'm rather inclined to drop support for Swift 5.2-5.4 instead of trying to support them via compiler directives.
There will be some updates in Generator/Package.swift
and .github/workflows/ci.yml
. There are likely going to be updates to the CI in #416, so perhaps wait until that lands.
@vsanthanam is there any way we can merge it? Tinder iOS team is migrating some stuff to support Swift Concurrency and looks like we need this changes. Would you be able to merge them in? Thanks.
See #472