needle icon indicating copy to clipboard operation
needle copied to clipboard

Annotate types, generated code with @MainActor

Open vsanthanam opened this issue 2 years ago • 4 comments

Proof of concept to allow UIKit dependencies to exist in the DI graph with with Swift Concurrency

vsanthanam avatar Jun 17 '22 13:06 vsanthanam

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 23 '22 22:06 CLAassistant

It looks like to do this we'll need to drop support for Swift < 5.5.

I'm rather inclined to drop support for Swift 5.2-5.4 instead of trying to support them via compiler directives.

There will be some updates in Generator/Package.swift and .github/workflows/ci.yml. There are likely going to be updates to the CI in #416, so perhaps wait until that lands.

wbond avatar Jul 06 '22 16:07 wbond

@vsanthanam is there any way we can merge it? Tinder iOS team is migrating some stuff to support Swift Concurrency and looks like we need this changes. Would you be able to merge them in? Thanks.

tinder-igornovik avatar Sep 21 '23 23:09 tinder-igornovik

See #472

tinder-cfuller avatar Mar 02 '24 22:03 tinder-cfuller