nebula.gl icon indicating copy to clipboard operation
nebula.gl copied to clipboard

EditingMode() doesnt work in version 1.02

Open cubecleveland opened this issue 3 years ago • 8 comments

Simply using the new version and changin the mode to EditingMode doesnt work, downgrading to 0.18.4 ad the sandbox example fixes the issue. Are we missing something ?

cubecleveland avatar Jan 14 '22 16:01 cubecleveland

I'll take a look.

igorDykhta avatar Jan 14 '22 17:01 igorDykhta

Thanks. Just FYI noe using nebula.gl just the simple react-map-gl-draw with a combo of React-map-gl and mapbox. We are in the process of switching from Leaflet to the his library

cubecleveland avatar Jan 14 '22 17:01 cubecleveland

Sorry to be a nusance, But can you guys confirm that this is indeed a bug ? If so is there any version we can downgrade too so we can at least get this basic feature working ?

cubecleveland avatar Jan 16 '22 00:01 cubecleveland

@cubecleveland I'm using v0.21.1 and it seems to be working fine. It seems to be a bug since v0.22.1 as you can see here: https://github.com/uber/nebula.gl/issues/580

ecfaria avatar Jan 20 '22 13:01 ecfaria

Thanks, does it work also with initial features passed on ? so if i want to have initial features already in the edit mode ? seems to not work if i go that route

cubecleveland avatar Jan 25 '22 21:01 cubecleveland

For me it works fine with initial features. I have a modal to create regions and to edit them, and in both the editing mode works fine. It seems they merged a fix for this at the end of last year, but it still doesn't work for me.

ecfaria avatar Jan 26 '22 14:01 ecfaria

This issue should be fixed on the current master

igorDykhta avatar Feb 06 '22 00:02 igorDykhta

Getting the same error on #723

varna avatar Feb 18 '22 11:02 varna