nebula.gl icon indicating copy to clipboard operation
nebula.gl copied to clipboard

Remove @danmarshall/deckgl-typing from dependecies of nebula.gl/layer

Open abouroubi opened this issue 4 years ago • 3 comments

Describe the bug

I'm using nebula.gl with Typescript and react, unfortunately the non official @danmarshall/deckgl-typing are lacking good typings for deck.gl, but they are installed as a dependency of nebula.gl/layer, and prevent my project from compiling. As of now typescript doesn't have a proper way to override typings that are in node_module/type, so we can't even find a workaround for it.

Actual Result

Expected Result

Reproduce Steps

Screenshots

To Do List

  • [ ] Add label and assign to milestone
  • [ ] Coding
  • [ ] Test

abouroubi avatar Feb 16 '21 17:02 abouroubi

@abouroubi If you need a workaround for changing the types yourself, you might find patch-package useful.

sangaline avatar Mar 02 '21 16:03 sangaline

Hello, is there any news about this ? I see that it was assigned to @kargeor but I don't now if it has been seen or not ?

I think the best practice is to put typings packages in the devDependencies instead.

abouroubi avatar Feb 02 '22 11:02 abouroubi

@abouroubi I'll take a look.

igorDykhta avatar Feb 02 '22 15:02 igorDykhta