motif
motif copied to clipboard
uber
A simple DI API for Android / Java
Note for reviewers: I have NOT tested this against Uber's apps at the time of this writing - this pull request is more of a "is this even a problem...
(Uber employees may reference the original doc: [here](https://docs.google.com/document/d/1q9pr6Gxf7mGB2pxTTOIZC2nC-bt10AqzUews57wkRvk/edit)) An issue can occur when using ScopeFactory to connect a parent and child scope to one another. Dependencies listed in a hand-made...
**Description**: When we have self types (implemented by recursive generics), Motif fails with `StackOverflowError`: ``` at com.uber.xprocessing.ext.XTypeKt.hasCollectionType(XType.kt:316) at com.uber.xprocessing.ext.XTypeKt.hasCollectionType(XType.kt:316) at com.uber.xprocessing.ext.XTypeKt.hasCollectionType(XType.kt:316) ... ``` The following code seems to trigger that...
The DI graph generation throws `StackOverflowError` when using specific generics combination. **Library version**: `0.4.0-alpha05` **Repro steps or stacktrace**: To repro we need to use `@motif.Object` inheritance functionality. The generic type...
**Description**: Currently we use a deprecated `LineMarkerInfo` call in 3 places. The call we are using is [marked for removal](https://github.com/jetbrains/intellij-community/blob/master/platform/lang-api/src/com/intellij/codeInsight/daemon/LineMarkerInfo.java#L150), and causes non-fatal errors in the latest version of IntelliJ...
The motif gutter icon doesn't show up for Kotlin scopes and they do not appear in the scope list (even after a refresh. **Library version**: `v0.0.3` **IntelliJ version**: `2018.3.5` **Repro...
We observed two different issues with inner classes in generated code (see f390eb3c4971046322dd1a07f50eed97c42c571f 6a2e7821ae6ffd41e8bae692a00bb498f9c3541b). While this is an edge case which is not reproducible in every environment it would still...
Does this or will it ever support purely kotlin-based multi-platform projects that do not run on the jvm?
Generated code seems to ignore given instance for the dependency source while using ScopeFactory with a single unused dependency and tries to create the instance directly. **Library version**: 0.3.3-SNAPSHOT **Repro...
This makes using Kotlin code generation mode impossible when `allWarningsAsErrors` is enabled. See https://github.com/uber/motif/pull/205. This time it's because the generated method signature doesn't match for binds factory methods. A few...
