h3-py icon indicating copy to clipboard operation
h3-py copied to clipboard

Add python 3.12 wheels on v3.7

Open msaecker opened this issue 1 year ago • 4 comments

Extend the exisiting build pipeline to create python 3.12 wheels.

msaecker avatar Feb 26 '24 10:02 msaecker

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 26 '24 10:02 CLAassistant

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (f8958ac) to head (8f88192).

Additional details and impacted files
@@            Coverage Diff            @@
##                v3      #344   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          425       425           
=========================================
  Hits           425       425           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '24 22:02 codecov[bot]

This does not seem to be building correctly? https://github.com/uber/h3-py/actions/runs/8047484474/job/22005886719?pr=344

isaacbrodsky avatar Feb 26 '24 22:02 isaacbrodsky

This does not seem to be building correctly? https://github.com/uber/h3-py/actions/runs/8047484474/job/22005886719?pr=344

Yeah, the cibuildwheel version did not support python 3.12 yet. I upgraded to the newest one. The earliest stable ABI was in version 2.15, with the final CPython 3.12 in v2.16.2.

msaecker avatar Feb 27 '24 07:02 msaecker

I cherry-picked some commits from main dropping c1 builds and python 2.7 & 3.5. I also added a commit dropping 3.6.

msaecker avatar Feb 29 '24 07:02 msaecker

The cherry-picking seems to have overwritten the cibuildversion to 2.16.2 instead of 2.16.5, but that should be fine as it contains a final CPython version for 3.12. I have no idea why the windows build failed and this is as far as I am taking this PR.

msaecker avatar Mar 01 '24 07:03 msaecker

Upgraded cibuildwheel back to 2.16.5 as this might be the cause of the windows build issues.

msaecker avatar Mar 04 '24 08:03 msaecker

All green.

msaecker avatar Mar 06 '24 07:03 msaecker

This looks good. Thanks @msaecker!

ajfriend avatar Mar 09 '24 17:03 ajfriend