h3-py icon indicating copy to clipboard operation
h3-py copied to clipboard

Support PEP 517 builds

Open Zaczero opened this issue 1 year ago • 3 comments

When attempting to install the h3:

Note: This error originates from the build backend, and is likely not a problem with poetry but with h3 (3.7.6) not supporting PEP 517 builds. You can verify this by running 'pip wheel --no-cache-dir --use-pep517 "h3 (==3.7.6)"'.

Zaczero avatar Jan 08 '24 19:01 Zaczero

Yes. I'd like to improve the current build setup, possibly using https://scikit-build-core.readthedocs.io/

PRs more than welcome in the meantime!

ajfriend avatar May 28 '24 17:05 ajfriend

I was reading "modern build setup" these days. It seems that the Cython support in scikit-build-core is still in development: https://scikit-build-core.readthedocs.io/en/latest/getting_started.html#source-code but it may have everything we need?

I was looking into meson/meson-python as well. There are currently used in scipy and scikit-image. https://meson-python.readthedocs.io/en/latest/

wingkitlee0 avatar May 28 '24 22:05 wingkitlee0

Do you know if meson works well with CMake? The H3 C library uses CMake, so we need to interface with it. IIRC, this is why we were using scikit-build originally.

Aside from meson, scikit-build-core does look promising, I just haven't had a chance to try building with it.

ajfriend avatar May 29 '24 03:05 ajfriend