h3-py icon indicating copy to clipboard operation
h3-py copied to clipboard

Build wheels from sdist

Open ajfriend opened this issue 3 years ago • 5 comments

This makes it so that we don't need to test the sdist separately. It will be tested automatically since cibuildwheel will build directly from only the, and verify that the tests pass.

ajfriend avatar Jun 04 '22 20:06 ajfriend

Codecov Report

Merging #258 (6995001) into dev_v4 (cfbd892) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            dev_v4      #258   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          425       425           
=========================================
  Hits           425       425           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfbd892...6995001. Read the comment docs.

codecov[bot] avatar Jun 04 '22 20:06 codecov[bot]

Possible interim backup plan: just use the command line version of the cibuildwheel tool, instead of the github action?

ajfriend avatar Jun 07 '22 05:06 ajfriend

What would using the CLI solve instead of the action? It would be surprising if there's something you can do with the CLI that you can't with the action

kylebarron avatar Jun 07 '22 15:06 kylebarron

In the scheme of things that are necessary for v4.. should this be included? The existing wheel building process seems to work fine for me

kylebarron avatar Jun 07 '22 15:06 kylebarron

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: ajfriend
:x: Isaac Brodsky


Isaac Brodsky seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 16 '23 07:02 CLAassistant