uber
Add release workflow
Pull Request Test Coverage Report for Build #518
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 94.437%
| Totals | |
|---|---|
| Change from base Build #513: | 0.0% |
| Covered Lines: | 523 |
| Relevant Lines: | 546 |
💛 - Coveralls
Fixes #160
Adds the release workflow for automated releases using tags like v4.2.0
For simplicity, I copied the build parts into the release.yml workflow even though they are recomputing some artifacts from the tests.yml workflow. Alternately, I would need to add the release job to tests.yml and set up the dependencies there.
cc @nrabinowitz
Has this had an end-to-end test on a dummy repo? Any open questions on functional correctness? If so, is the plan to fix foward upon an issue? Would be great to have the verification documented in PR description.
Has this had an end-to-end test on a dummy repo? Any open questions on functional correctness? If so, is the plan to fix foward upon an issue? Would be great to have the verification documented in PR description.
No, I have not had an opportunity to test this on a dummy repo. My plan was to fix forward as this repo has a relatively unique and complicated build process.
If desired I could set up a new artifact on Maven Central and demonstrate this script is capable of pushing that first?
I was able to get "published" status using my own namespace publishing in Sonatype Central Repository. (It doesn't show up on Maven Central Search, I think this is either a delay in showing up there or because I used staging URLs, in the second case that part was unique to my repo and in this PR I used the provided URLs. Since it is not my account I cannot validate that part of the process :) )
The only outstanding issue is that the release notes generated get the entire contents of CHANGELOG, this is easy to manually fix after release. I will try to fix that but I don't think that is blocking.
It appears my copy published correctly: https://repo1.maven.org/maven2/io/github/isaacbrodsky/h3/
I'll update the changelog date for 4.3.0, merge, and try releasing in the next few days.