clay icon indicating copy to clipboard operation
clay copied to clipboard

add an interface for bulk sending stats

Open eklitzke opened this issue 11 years ago • 3 comments

This change is motivated by a similar interface that @sophiaxc and I made for an internal project. The idea for that project was that each iteration of this loop was sending a lot of statsd metrics namespaced by the project name, and so an interface where the connection had the prefix and could do bulk sending of stats was a big improvement.

eklitzke avatar Jan 14 '14 02:01 eklitzke

Looks good! What do you think of also having a context that batches those stats?

charlax avatar Jan 14 '14 04:01 charlax

This is a really good idea @charlax, I will send an updated PR.

eklitzke avatar Jan 14 '14 05:01 eklitzke

Please add a unit test or two, just so we've got some level of coverage.

JeremyGrosser avatar Jan 31 '14 01:01 JeremyGrosser