cadence
cadence copied to clipboard
feat: Add cron schedule to customized search attribute
Detailed Description Add cron schedule to visibility customized search attribute
WORKFLOW TYPE | WORKFLOW ID | RUN ID | TASK LIST | IS CRON | START TIME | EXECUTION TIME | END TIME | CLOSE STATUS | HISTORY LENGTH | UPDATE TIME | SEARCH ATTRIBUTES
helloWorldWorkflow | helloworld_0261b29c-5163-4e9d-ab36-fe3449e340c3 | 98dd5f8b-d506-4400-b7d5-12aa672a875e | helloWorldGroup | false | 13:31:29 | 13:31:29 | 13:31:29 | COMPLETED | 11 | 16:00:00 | BinaryChecksums:[2172e88e8a2485381bab46576c92773e]
main.sampleCronWorkflow | cron_e81476f5-ebeb-453d-b2c3-de941c19d46c | d17f7043-2836-4d22-bbc4-8659c7cbeba0 | cronGroup | true | 13:28:00 | 13:30:00 | 13:30:00 | CONTINUED_AS_NEW | 11 | 16:00:00 | CronSchedule:*/2 * * * *
Impact Analysis
- Backward Compatibility: Yes, it might not be backward compatible for users with same name of attribute already being used. It will get override by this value
- Forward Compatibility: Yes
Testing Plan
- Unit Tests: Yes, and manual tested
- Persistence Tests: [If the change is related to a data type which is persisted, do we have persistence tests covering the change?]
- Integration Tests: [Do we have integration test covering the change?]
- Compatibility Tests: [Have we done tests to test the backward and forward compatibility?]
Rollout Plan
- What is the rollout plan? Normal rollout
- Does the order of deployment matter? No
- Is it safe to rollback? Does the order of rollback matter? Yes
- Is there a kill switch to mitigate the impact immediately? NA
- Backward Compatibility: Yes It might not be backward compatible for users with same naming of attribute
Let's add a comment in the description saying if user has their CronSchedule field defined in the customized search attribute, their field's value will be override by our value. And it could leave compatibility issues as two version of CronSchedule might differ.
That is a good idea, I will also mention this in the release note