cadence
cadence copied to clipboard
Update matching handlers to return TaskListPartitionConfig in responses
What changed?
- Update matching handlers to return TaskListPartitionConfig in responses
- Update non-root partition to load partition config from database
Why? To migrate tasklist partition config from dynamic config to database
How did you test it? unit tests
Potential risks
Release notes
Documentation Changes
Codecov Report
Attention: Patch coverage is 84.07643% with 25 lines in your changes missing coverage. Please review.
Project coverage is 73.86%. Comparing base (
877ccae) to head (3952659). Report is 4 commits behind head on master.
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| common/persistence/data_manager_interfaces.go | 94.91% <100.00%> (+0.20%) |
:arrow_up: |
| service/matching/handler/handler.go | 100.00% <100.00%> (ø) |
|
| service/matching/tasklist/db.go | 83.87% <90.32%> (+13.62%) |
:arrow_up: |
| service/matching/tasklist/task_list_manager.go | 72.08% <91.07%> (+4.22%) |
:arrow_up: |
| service/matching/handler/engine.go | 82.61% <70.17%> (-0.07%) |
:arrow_down: |
... and 9 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9b75b7d...3952659. Read the comment docs.