cadence icon indicating copy to clipboard operation
cadence copied to clipboard

Update matching handlers to return TaskListPartitionConfig in responses

Open Shaddoll opened this issue 1 year ago • 1 comments

What changed?

  • Update matching handlers to return TaskListPartitionConfig in responses
  • Update non-root partition to load partition config from database

Why? To migrate tasklist partition config from dynamic config to database

How did you test it? unit tests

Potential risks

Release notes

Documentation Changes

Shaddoll avatar Oct 18 '24 21:10 Shaddoll

Codecov Report

Attention: Patch coverage is 84.07643% with 25 lines in your changes missing coverage. Please review.

Project coverage is 73.86%. Comparing base (877ccae) to head (3952659). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
service/matching/handler/engine.go 70.17% 15 Missing and 2 partials :warning:
service/matching/tasklist/task_list_manager.go 91.07% 4 Missing and 1 partial :warning:
service/matching/tasklist/db.go 90.32% 2 Missing and 1 partial :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
common/persistence/data_manager_interfaces.go 94.91% <100.00%> (+0.20%) :arrow_up:
service/matching/handler/handler.go 100.00% <100.00%> (ø)
service/matching/tasklist/db.go 83.87% <90.32%> (+13.62%) :arrow_up:
service/matching/tasklist/task_list_manager.go 72.08% <91.07%> (+4.22%) :arrow_up:
service/matching/handler/engine.go 82.61% <70.17%> (-0.07%) :arrow_down:

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b75b7d...3952659. Read the comment docs.

codecov[bot] avatar Oct 19 '24 17:10 codecov[bot]