Minor metrics / log improvement for global ratelimiter
Ran into some issues building a dashboard with these, as "worker_domain_name" does not automatically relate to "domain-name", and addressing that is... sadly difficult in our monitoring systems. Regardless, I think using local keys is probably better. We already have the collection name in logs and metrics, and this way you can search for the domain name and find all of these at once (easier for browsing randomly) and it's no harder to narrow down either (just also search by collection).
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.02%. Comparing base (
1b02d78) to head (6528b3a). Report is 1 commits behind head on master.
Additional details and impacted files
| Files with missing lines | Coverage Δ | |
|---|---|---|
| common/quotas/global/collection/collection.go | 85.02% <100.00%> (ø) |
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 1b02d78...6528b3a. Read the comment docs.
discussed offline: tl;dr yes to my question