cadence icon indicating copy to clipboard operation
cadence copied to clipboard

Add unit tests for remaining methods in history handler

Open timl3136 opened this issue 1 year ago • 1 comments

What changed? Add unit tests for remaining methods in history handler

Why? Improve test coverage

How did you test it? Unit tests

Potential risks

Release notes

Documentation Changes

timl3136 avatar May 10 '24 23:05 timl3136

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.70%. Comparing base (dbfb1c8) to head (7a45746). Report is 6 commits behind head on master.

:exclamation: Current head 7a45746 differs from pull request most recent head 8d18680. Consider uploading reports for the commit 8d18680 to get more accurate results

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbfb1c8...8d18680. Read the comment docs.

codecov[bot] avatar May 10 '24 23:05 codecov[bot]

Pull Request Test Coverage Report for Build 018f72cc-a7f2-4561-9352-a91052becccb

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.07%) to 69.172%

Files with Coverage Reduction New Missed Lines %
common/task/weighted_round_robin_task_scheduler.go 2 89.05%
service/history/execution/mutable_state_util.go 2 78.52%
common/task/fifo_task_scheduler.go 4 85.57%
service/frontend/api/handler.go 4 62.26%
service/history/engine/engineimpl/poll_mutable_state.go 9 74.16%
<!-- Total: 21
Totals Coverage Status
Change from base Build 018f64a5-5902-4625-9851-849d5f6abde3: 0.07%
Covered Lines: 101624
Relevant Lines: 146915

💛 - Coveralls

coveralls avatar May 13 '24 16:05 coveralls