cadence
cadence copied to clipboard
uber
Fix history corruption check for workflow signaling
What changed?
- Do not convert persistence transient errors to history corruption errors
- Fix history corruption check for workflow signaling
Why?
- When the system is overloaded or there is something wrong with the underlying database, we may receive some transient errors and not able to determine if a workflow is resurrected, but we still treat those workflows as resurrected which is wrong.
How did you test it? staging2
Potential risks
Release notes
Documentation Changes
Pull Request Test Coverage Report for Build 018366d9-943d-49a2-8126-964c84d02c09
- 6 of 38 (15.79%) changed or added relevant lines in 2 files are covered.
- 60 unchanged lines in 14 files lost coverage.
- Overall coverage decreased (-0.008%) to 57.212%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| service/history/historyEngine.go | 6 | 14 | 42.86% |
| service/history/execution/mutable_state_builder.go | 0 | 24 | 0.0% |
| <!-- | Total: | 6 | 38 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| common/task/weightedRoundRobinTaskScheduler.go | 1 | 89.64% |
| client/history/client.go | 2 | 38.1% |
| client/history/metricClient.go | 2 | 45.3% |
| common/cache/lru.go | 2 | 92.2% |
| common/util.go | 2 | 52.44% |
| service/history/handler.go | 2 | 47.3% |
| service/history/shard/context.go | 2 | 66.52% |
| service/matching/matcher.go | 2 | 91.46% |
| common/persistence/nosql/nosqlplugin/cassandra/workflow.go | 3 | 59.55% |
| common/persistence/statsComputer.go | 3 | 93.57% |
| <!-- | Total: | 60 |
| Totals | |
|---|---|
| Change from base Build 0183668d-fdb0-4e9f-94ed-111eed41a3d5: | -0.008% |
| Covered Lines: | 85036 |
| Relevant Lines: | 148634 |
