cadence
cadence copied to clipboard
uber
Drop stuck workflow timeout timer task
What changed?
- Drop workflow timeout timer task if the error is conditional error or workflow start event missing error
- Drop stuck tasks only after a few retries
- Update related metrics
Why? Lots of resurrected workflow history.
How did you test it? This feature is controlled by a feature-flag and we can enable it domain by domain. Some of the logic is already tested in production. The new logic can be tested in a staging environment.
Potential risks
Release notes
Documentation Changes
Pull Request Test Coverage Report for Build 01838576-7ac9-40ec-91de-07812c563d4c
- 5 of 21 (23.81%) changed or added relevant lines in 1 file are covered.
- 129 unchanged lines in 15 files lost coverage.
- Overall coverage decreased (-0.05%) to 57.257%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| service/history/task/task.go | 5 | 21 | 23.81% |
| <!-- | Total: | 5 | 21 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| service/history/queue/timer_queue_processor_base.go | 1 | 77.26% |
| common/cache/lru.go | 2 | 92.2% |
| common/persistence/historyManager.go | 2 | 66.67% |
| service/history/execution/mutable_state_builder.go | 2 | 68.63% |
| service/history/task/transfer_active_task_executor.go | 2 | 72.15% |
| service/matching/matcher.go | 2 | 91.46% |
| common/persistence/serialization/parser.go | 4 | 62.41% |
| common/persistence/serialization/thrift_decoder.go | 4 | 53.06% |
| service/history/task/fetcher.go | 4 | 91.24% |
| service/frontend/workflowHandler.go | 7 | 59.98% |
| <!-- | Total: | 129 |
| Totals | |
|---|---|
| Change from base Build 01837e07-4f5c-45fa-bc7e-c21cfae9b732: | -0.05% |
| Covered Lines: | 85127 |
| Relevant Lines: | 148676 |
