cadence Increase default timeout seconds for Reset command and add description about timeout issues

Increase default timeout seconds for Reset command and add description about timeout issues

Open longquanzheng opened this issue 4 years ago • 5 comments

Is your feature request related to a problem? Please describe. Using Reset command with CLI will get code:deadline-exceeded message:timeout easily because reset requires replay in the server. It's quite resource consuming, depending on the length/size of the history.

By default the CLI context timeout is only 5 seconds: https://github.com/uber/cadence/blob/63bdb5d7a04285cf57992c574639c9d911c7001a/tools/cli/defs.go#L54

This is mostly not enough for production use cases.

Right now people can provide a global flag "--context_timeout" or "--ct" to override the timeout, but it's not friendly, and few people are ware of this global option.

Proposed Solution A clear and concise description of what you want to happen. Increase the default timeout of Reset command(only), to a value like 1 minute. Also add description to the Reset command to let people know that they can override it with the global options

Additional context Add any other context or screenshots about the feature request here. From a slack convo: https://uber-cadence.slack.com/archives/CL22WDF70/p1601986927134000