cadence icon indicating copy to clipboard operation
cadence copied to clipboard
verified publisher icon uber

Allow adding custom visibility attributes on reset

Open mfateev opened this issue 6 years ago • 5 comments

It would be useful to be able to add additional visibility attributes when issuing workflow reset. This way the reset workflows might be searched for.

Also it would be nice to automatically update the visibility record on reset with additional "wasReset" flag to support such searches out of the box.

mfateev avatar Jun 14 '19 17:06 mfateev

I am going to work on this issue today! I just want to double-check that this is not duplicate work.

ins-tril avatar Aug 19 '25 01:08 ins-tril

This is not implemented yet. Thanks a lot for taking this!

demirkayaender avatar Aug 19 '25 21:08 demirkayaender

@mfateev The requirements are not clear to me. Could you please elaborate them?

ins-tril avatar Aug 21 '25 07:08 ins-tril

You will need to add a new visibility field and assign its value when a workflow was created from a reset. Here are some old PRs adding a new field

  • https://github.com/cadence-workflow/cadence/pull/4176
  • https://github.com/cadence-workflow/cadence-go-client/pull/1095
  • https://github.com/cadence-workflow/cadence-idl/pull/67

You might find newer PRs if you blame these files.

demirkayaender avatar Aug 22 '25 16:08 demirkayaender

Here are some more recent examples:

  • https://github.com/cadence-workflow/cadence/pull/4962
  • https://github.com/cadence-workflow/cadence/pull/4971

demirkayaender avatar Aug 22 '25 17:08 demirkayaender