cadence-java-client icon indicating copy to clipboard operation
cadence-java-client copied to clipboard

Remove unused code from cadence.internal package

Open natemort opened this issue 1 year ago • 2 comments

What changed? Remove unused code from internal packages to improve code coverage and reduce maintenance burden. Users shouldn't be accessing internals.

Why? Improving code coverage and reducing maintenance burden

How did you test it? Unit tests

Potential risks User code may be accessing internals within the client and could break. Generally this should be a compile time breakage and we do not support accessing internals.

Release notes

Documentation Changes

natemort avatar Oct 17 '24 21:10 natemort

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@6d3f55f). Learn more about missing BASE report.

Additional details and impacted files
Files with missing lines Coverage Δ
...adence/internal/common/WorkflowExecutionUtils.java 46.55% <ø> (ø)
.../internal/replay/ActivityDecisionStateMachine.java 77.41% <ø> (ø)
...rnal/replay/ChildWorkflowDecisionStateMachine.java 45.61% <ø> (ø)
...ce/internal/replay/SignalDecisionStateMachine.java 57.14% <ø> (ø)
...nce/internal/replay/TimerDecisionStateMachine.java 80.00% <ø> (ø)
...ternal/sync/SimulatedTimeoutExceptionInternal.java 100.00% <ø> (ø)
...uber/cadence/internal/sync/SyncWorkflowWorker.java 81.81% <ø> (ø)
...m/uber/cadence/internal/sync/WorkflowInternal.java 87.62% <ø> (ø)
...cadence/internal/sync/WorkflowRetryerInternal.java 83.05% <ø> (ø)
...va/com/uber/cadence/internal/worker/Throttler.java 0.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d3f55f...c937660. Read the comment docs.

codecov[bot] avatar Oct 17 '24 21:10 codecov[bot]

Pull Request Test Coverage Report for Build 2542

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.4%) to 65.75%

Files with Coverage Reduction New Missed Lines %
src/main/java/com/uber/cadence/internal/sync/WorkflowRetryerInternal.java 1 86.44%
src/main/java/com/uber/cadence/internal/sync/WorkflowThreadContext.java 1 81.58%
src/main/java/com/uber/cadence/internal/worker/Poller.java 1 78.13%
src/main/java/com/uber/cadence/internal/replay/ReplayDecider.java 5 80.27%
<!-- Total: 8
Totals Coverage Status
Change from base Build 2537: 0.4%
Covered Lines: 12741
Relevant Lines: 19378

💛 - Coveralls

coveralls avatar Oct 17 '24 22:10 coveralls