uber
Support Two-legged OAuth flow
What changed? Adding generic, client-credentials OAuth 2 support.
Why? There is self-signed JWT provider already implemented. Adding client credentials flow support.
How did you test it? Added unit test.
Potential risks
Release notes
Documentation Changes
Pull Request Test Coverage Report for Build 2290
Details
- 11 of 33 (33.33%) changed or added relevant lines in 2 files are covered.
- 2 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.02%) to 60.304%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/main/java/com/uber/cadence/serviceclient/auth/OAuthAuthorizationProvider.java | 11 | 15 | 73.33% |
| src/main/java/com/uber/cadence/internal/compatibility/proto/serviceclient/GrpcServiceStubs.java | 0 | 18 | 0.0% |
| <!-- | Total: | 11 | 33 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| src/main/java/com/uber/cadence/internal/sync/WorkflowThreadContext.java | 1 | 81.58% |
| src/main/java/com/uber/cadence/internal/worker/BlockCallerPolicy.java | 1 | 62.5% |
| <!-- | Total: | 2 |
| Totals | |
|---|---|
| Change from base Build 2289: | -0.02% |
| Covered Lines: | 11696 |
| Relevant Lines: | 19395 |
💛 - Coveralls
It seems that OAuth is only supported in GRPC. Are we planning to make changes to Tchannel as well?
It seems that OAuth is only supported in GRPC. Are we planning to make changes to Tchannel as well?
@shijiesheng TChannel has OAuth capabilities already. In this PR I'm adding gRPC OAuth support as well
Hey @mantas-sidlauskas , can you bump the oauth client version to avoid https://www.cve.org/CVERecord?id=CVE-2021-22573 ? I'm happy to merge once that's addressed.
